Skip to content

Fixed when IN query statement didn't work with Long values#36249

Merged
rinatmini merged 4 commits into
mainfrom
users/rinatmini/springfix
Aug 5, 2023
Merged

Fixed when IN query statement didn't work with Long values#36249
rinatmini merged 4 commits into
mainfrom
users/rinatmini/springfix

Conversation

@rinatmini

@rinatmini rinatmini commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Description

Related issue: #36209

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Aug 4, 2023
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@kushagraThapar kushagraThapar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @rinatmini
Thanks for the fix, once you make it ready for review, we can run the CI to check if this has any side effects or not.

Comment thread sdk/spring/azure-spring-data-cosmos/CHANGELOG.md Outdated
@kushagraThapar

Copy link
Copy Markdown
Member

run /azp java - spring - cosmos

@kushagraThapar

Copy link
Copy Markdown
Member

/azp run java - spring - cosmos

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rinatmini
rinatmini marked this pull request as ready for review August 4, 2023 23:00
@rinatmini
rinatmini enabled auto-merge (squash) August 4, 2023 23:14
#### Breaking Changes

#### Bugs Fixed
* Fixed when IN statement in annotated query didn't work with Long values - See [PR 36249](https://github.com/Azure/azure-sdk-for-java/pull/36249).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed when IN statement in annotated query didn't work with Long values - See [PR 36249](https://github.com/Azure/azure-sdk-for-java/pull/36249).
* Fixed an issue with IN statement in annotated queries not working for `Long` data type - See [PR 36249](https://github.com/Azure/azure-sdk-for-java/pull/36249).

@rinatmini
rinatmini merged commit c2c2979 into main Aug 5, 2023
@rinatmini
rinatmini deleted the users/rinatmini/springfix branch August 5, 2023 01:17
rinatmini added a commit that referenced this pull request Aug 7, 2023
* Fixed when IN query statement didn't work with Long values

* Warn fix

* Build warnings were fixed

* Added more tests + resolved PR comments
rinatmini added a commit that referenced this pull request Aug 7, 2023
…rry pick from main) (#36267)

* Fixed when IN query statement didn't work with Long values (#36249)

* Fixed when IN query statement didn't work with Long values

* Warn fix

* Build warnings were fixed

* Added more tests + resolved PR comments

* Fixed typo in CHANGELOG + dummy change in test to trigger CI pipeline (#36255)

* Fixed PR link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants